Feature/system assignment group#796
Open
konac-hamza wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#757 System group role assignment API
This PR covers CRUD operations for system role assignments of group actors.
When listing roles for a system group, the API was returning all system role assignments in the database instead of only those belonging to the requested group. The root cause was that
group_idwas never added to the actors filter inlist_assignments, whileuser_idwas handled correctly. With an empty actors list, the database query had no filter and returned every system assignment. The fix was addinggroup_idto the actors list the same wayuser_idis handled.