Skip to content

Add additionalMCPServers for external MCP servers - #91

Draft
sdatko wants to merge 1 commit into
openstack-k8s-operators:mainfrom
sdatko:additional-mcps
Draft

sdatko wants to merge 1 commit into
openstack-k8s-operators:mainfrom
sdatko:additional-mcps

Conversation

@sdatko

@sdatko sdatko commented Sep 18, 2026

Copy link
Copy Markdown

The mcp_servers section of the generated lightspeed-stack config was hardcoded to only the two rhos-mcps entries (rhoso-ocp-tools, rhoso-osp-tools), with no way to plug in other in-cluster MCP servers such as korrel8r or a Prometheus MCP.

This commit adds additionalMCPServers option, containing a list of {name, url, authorizationHeaders} entries appended to mcp_servers independently of the rhoso_mcps feature flag, so it works even when the rhos-mcps sidecar itself is disabled.

The authorizationHeaders is a free-form header-name -> mode map mirroring lightspeed-stack's own authorization_headers schema, since different MCP servers expect different header conventions (e.g. korrel8r's plain Authorization: Bearer vs. rhos-mcps's OCP_TOKEN/OS_TOKEN).

This is an experimental feature: lives under the unstable dev.* block just like the existing rhosMCP options, no CRD schema change needed since Dev is a RawExtension.

Assisted by: Claude Sonnet 5

The mcp_servers section of the generated lightspeed-stack config
was hardcoded to only the two rhos-mcps entries (rhoso-ocp-tools,
rhoso-osp-tools), with no way to plug in other in-cluster MCP servers
such as korrel8r or a Prometheus MCP.

This commit adds additionalMCPServers option, containing a list of
{name, url, authorizationHeaders} entries appended to mcp_servers
independently of the rhoso_mcps feature flag, so it works even
when the rhos-mcps sidecar itself is disabled.

The authorizationHeaders is a free-form header-name -> mode map
mirroring lightspeed-stack's own authorization_headers schema,
since different MCP servers expect different header conventions
(e.g. korrel8r's plain Authorization: Bearer vs. rhos-mcps's
OCP_TOKEN/OS_TOKEN).

This is an experimental feature: lives under the unstable dev.* block
just like the existing rhosMCP options, no CRD schema change needed
since Dev is a RawExtension.

Assisted by: Claude Sonnet 5
@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdatko
Once this PR has been reviewed and has the lgtm label, please assign akrog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant