fix: fix the issue of failed title switching after using the quill-header-list plugin - #475
fix: fix the issue of failed title switching after using the quill-header-list plugin#475wuyiping0628 wants to merge 1 commit into
Conversation
…eader-list plugin
WalkthroughThe Fluent Editor header toolbar handlers now convert header levels to numbers and pass ChangesHeader toolbar formatting
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/docs/fluent-editor/demos/header-list-container.vue (1)
29-31: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a regression test for header selection and clearing.
The existing specs verify initial headings and header-list visibility, but they do not exercise this handler. Add tests in
packages/docs/fluent-editor/demos/header-list.spec.tsandpackages/docs/fluent-editor/demos/header-list-container.spec.tsthat select a heading level and then select the reset option.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/docs/fluent-editor/demos/header-list-container.vue` around lines 29 - 31, Add regression coverage for the header(value) handler in both header-list.spec.ts and header-list-container.spec.ts: select a heading level, assert the editor applies that header, then select the reset option and assert the header formatting is cleared. Reuse the existing demo test setup and selectors without changing the handler behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/docs/fluent-editor/demos/header-list-container.vue`:
- Around line 29-31: Add regression coverage for the header(value) handler in
both header-list.spec.ts and header-list-container.spec.ts: select a heading
level, assert the editor applies that header, then select the reset option and
assert the header formatting is cleared. Reuse the existing demo test setup and
selectors without changing the handler behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c03ac424-4fcc-4fd8-b388-41f8cea9be94
📒 Files selected for processing (2)
packages/docs/fluent-editor/demos/header-list-container.vuepackages/docs/fluent-editor/demos/header-list.vue
解决用了quill-header-list插件后切换标题失败的问题
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit