Skip to content

refactor(sdk): type group members access via _get_relationship_many #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saltas888 wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −2
Open

refactor(sdk): type group members access via _get_relationship_many #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/+query-groups-typed-members-accessor.housekeeping.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Routed the two remaining `existing_group.members.peer_ids` accesses in `infrahub_sdk/query_groups.py` through the typed `_get_relationship_many(name="members")` accessor, removing the last two `# type: ignore[union-attr]` suppressions in that module. Internal typing hygiene with no behavioural change.
8 changes: 6 additions & 2 deletions infrahub_sdk/query_groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ async def update_group(self) -> None:
return

# Calculate how many nodes should be deleted
self.unused_member_ids = list(set(existing_group.members.peer_ids) - set(members)) # type: ignore[union-attr]
self.unused_member_ids = list(
set(existing_group._get_relationship_many(name="members").peer_ids) - set(members)
)

if not self.delete_unused_nodes:
return
Expand Down Expand Up @@ -267,7 +269,9 @@ def update_group(self) -> None:
return

# Calculate how many nodes should be deleted
self.unused_member_ids = list(set(existing_group.members.peer_ids) - set(members)) # type: ignore[union-attr]
self.unused_member_ids = list(
set(existing_group._get_relationship_many(name="members").peer_ids) - set(members)
)

if not self.delete_unused_nodes:
return
Expand Down