Skip to content

Add unit tests for osism.utils.ssh #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ideaship merged 2 commits into from
Jul 3, 2026
+598 −1
Merged

Add unit tests for osism.utils.ssh #2350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c2f63c
Add unit tests for osism.utils.ssh
berendt Jun 12, 2026
f38f9be
Report SSH known_hosts cleanup as failed on non-zero ssh-keygen exit
berendt Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion osism/utils/ssh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,15 @@ def remove_known_hosts_entries(
else:
logger.debug(f"No SSH known_hosts entries found for {identifier}")
else:
# Log stderr for debugging but don't fail entirely
# ssh-keygen -R returns 0 even when the host is absent from the
# file, and the non-existent-file case is already short-circuited
# above. A non-zero exit therefore signals a genuine failure (e.g.
# a corrupt or unreadable known_hosts), so the cleanup did not
# succeed and a stale host key may survive.
logger.warning(
f"ssh-keygen returned non-zero exit code for {identifier}: {result.stderr.strip()}"
)
success = False

except subprocess.TimeoutExpired:
logger.error(
Expand Down
Loading