don't header-check the bhyve or viona API version - #1208
Closed
iximeow wants to merge 3 commits into
Closed
Conversation
Changes to viona and bhyve are generally additive, and backwards-compatible. Checking that the header API version definitions match those in Propolis is more restrictive than we are at runtime; generally beeing *newer* than the OS interface is OK, while *older* is not. If viona or bhyve changes are not backwards-compatible, header-check will still report them as applicable to items that Propolis has definitions of too. If changes simply remove items some twiddling with the header-check/build.rs rules may be in order, so that Propolis checked against older API versions can know that items which were once present are no longer.
iximeow
added
the
development
iximeow
force-pushed
the
ixi/hdrchk-viona-interface-ver
branch
from
August 31, 2026 17:35
de9b118 to
8dc769c
Compare
Merged
Member
Author
|
I've misunderstood the semantic of the interface version numbers for a while now, it turns out. they're just Private interface from the OS's perspective, and it is incorrect to assume you might be able to get correct function using for example an old Propolis on newer host bits. I'll have a subsequent change that describes this a bit on the Propolis side, but we just need to update Propolis' VIONA_CURRENT_INTERFACE_VERSION to match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since
5ffff4b(nice hash!) stlouis has had aVIONA_CURRENT_INTERFACE_VERSIONof 7, which differs from the existing minimum Propolis requires of 6. the last time this was changed was back when we added multi-queue support to viona, which predates me adding header-check as part of CI (... as a result of a bug that came in with that change!) ... when the CI illumos was updated in the last few weeks, the value we see in header-check finally got the update too. as-is, because the constant doesn't match between our definition and the kernel headers,header-checkhandles that as any other constant mismatch and fails CI. in any other case this would be right, such as if ioctl values were curiously changing around beneath our feet.. but here it's generally ok.while viona's header-check now supports a notion of
API_VERSION, I don't know of any items which have been removed and I don't want to add conflicts for new versions. so I'm adding it in here really in service of future use (perhaps in #1093?)this gets CI green again, which really had no need to be failing. sorry for the troubles @zeeshanlakhani