ci: run generated CLI parity in the existing lint job - #1968
Merged
Conversation
Collaborator
Author
|
Independent review: PASS at Sol/high security reviewer and Luna/high verifier both passed the exact combined head: existing CI parity target wiring, unsupported timing-comment removal and the styled-submit test correction. Author-run frontend suite: 636 passed, 0 failed. Reviewer independently reran the focused wizard domain (23 passed), actionlint, parity and diff checks. Remote required CI is pending; no browser click/CSS-overlay or OS runtime result is claimed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated CLI parity gate now runs in the existing lint job, so stale generated output and the target’s failure controls are checked in CI. The wizard probe test also accepts the styled submit button introduced by #1893 while still requiring that the button exists and is enabled; its previous literal markup assertion was failing unrelated PRs.
Validation at
937cfae237d4141649f3ae988effef5ed848b7e2: frontend 636 passed, 0 failed; actionlint; generated CLI parity including negative controls; diff check. Independent Sol/high security review and Luna/high verification are recorded separately. No new CI job or test framework.Closes #1925.