Warn when clearnet_initial_sync is silently defeated by the egress firewall - #955
Merged
Merged
Conversation
The two flags are silently self-defeating together: the firewall (default on) drops the very clearnet dials the sync flag asks for, so the sync just runs over Tor at ordinary speed and nothing says why. Warn, not fail — nothing leaks (the firewall is doing its job), the config is merely slower than intended, matching the codebase's precedent for self-defeating-but-harmless combinations. Placed in parse_and_validate_config so every validating command surfaces it. Four-quadrant tier-1 coverage; docs/privacy.md documents the either/or and names the scoped-exception follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #941's option (b) — the scoped-ACCEPT design stays on the issue. The two flags are self-defeating together: the firewall (default on) drops the very clearnet dials the sync flag asks for, so the sync just runs over Tor at ordinary speed and nothing says why. Both are wizard-reachable, so real users will pick the pair.
Warn, not fail — nothing leaks (the firewall is doing its job); the config is merely slower than intended, matching the codebase's precedent for self-defeating-but-harmless combinations (rationale in a comment at the check). Placed in parse_and_validate_config so every validating command surfaces it, doctor and edit included. Four-quadrant tier-1 coverage (fires on both contradictory pairs, silent on both sane ones); docs/privacy.md documents the either/or and names the unbuilt scoped exception honestly. Suite 2191/0 solo. Ponytail: one guarded warn.
🤖 Generated with Claude Code