feat(shortcuts): use game artwork for pinned icons - #259
Open
papi-ux wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
iconartwork through the existing memory, disk, and bounded fetch pathic_pc_scutas the fail-closed fallback when trusted game artwork is unavailablewhy
PR #257 intentionally landed the proven pinning contract first. its RP6 validation showed that Launcher3 received the generic Nova icon because the Polaris-native game-detail call hardcoded
iconBits = null.this follow-up keeps artwork separate while making the pinned home tile match the selected game.
verification
loadShortcutIcon()API5/5shortcut resolver, Activity wiring, adaptive bitmap, and resource-fallback tests18/181440/1440JVM tests passed, all three debug ABIs assembled1a71e06099ef6562405e69274c1c3e825e5b54e5RP6_-_Virtual_-_NEW, API 37, exact x86_64 APK SHA-2565bd358de5ce1559e3494941080a7c4b8176c5f7a4257b4dbd354c83926cfb85eiconRes=0, a persisted bitmap, exactShortcutTrampoline, host/game/HDR extras, and a visible home tile1.3.7/39debug APK restored byte-for-byte, pairing/library preserved, nova-lab stopped cleanly, physical Retroid untouchedboundaries
no poster cropping, second downloader, shortcut lifecycle expansion, release/tag, or physical-device mutation.