Skip to content

fix: Prevent crash when relation query constraint contains null #10647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 4 commits into
base: alpha
Choose a base branch
from
+30 −3
Open

fix: Prevent crash when relation query constraint contains null #10647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d08e30
fix: prevent crash when relation query constraint contains null
SAY-5 Aug 26, 2026
87c1a93
Merge branch 'alpha' into fix-relation-query-null-operand
SAY-5 Sep 27, 2026
2cdae6b
Merge branch 'alpha' into fix-relation-query-null-operand
SAY-5 Sep 28, 2026
609795e
Merge branch 'alpha' into fix-relation-query-null-operand
SAY-5 Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions spec/RestQuery.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,33 @@ describe('RestQuery.each', () => {
expect(resultsTwo.length).toBe(1);
});

it('should not throw when a relation query constraint contains null', async () => {
const objectA = new Parse.Object('Letter', { value: 'A' });
const object1 = new Parse.Object('Number', { value: '1' });
await object1.save();
objectA.relation('numbers').add(object1);
await objectA.save();

const config = Config.get('test');

for (const [restWhere, expectedCount] of [
[{ numbers: { $in: [null] } }, 0],
[{ numbers: { $nin: [null] } }, 1],
[{ numbers: { $ne: null, $in: [] } }, 0],
]) {
const query = await RestQuery({
method: RestQuery.Method.find,
config,
auth: auth.master(config),
className: 'Letter',
restWhere,
});
const results = [];
await query.each(result => results.push(result));
expect(results.length).toBe(expectedCount);
}
});

it('test afterSave response object is return', done => {
Parse.Cloud.beforeSave('TestObject2', function (req) {
req.object.set('tobeaddbefore', true);
Expand Down
6 changes: 3 additions & 3 deletions src/Controllers/DatabaseController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,13 +1096,13 @@ class DatabaseController {
if (constraintKey === 'objectId') {
relatedIds = [query[key].objectId];
} else if (constraintKey == '$in') {
relatedIds = query[key]['$in'].map(r => r.objectId);
relatedIds = query[key]['$in'].map(r => r?.objectId);
} else if (constraintKey == '$nin') {
isNegation = true;
relatedIds = query[key]['$nin'].map(r => r.objectId);
relatedIds = query[key]['$nin'].map(r => r?.objectId);
} else if (constraintKey == '$ne') {
isNegation = true;
relatedIds = [query[key]['$ne'].objectId];
relatedIds = [query[key]['$ne']?.objectId];
} else {
return;
}
Expand Down