Skip to content

remove correlation code - #1761

Merged
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:remove/correlation
Aug 20, 2026
Merged

remove correlation code#1761
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:remove/correlation

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Removed Features
    • Removed correlation management functionality, including listing, viewing, creating, updating, and deleting correlations.
    • Correlation API endpoints are no longer available.
    • Correlations are no longer loaded during startup or included in home search results.
    • Removed correlation-related permissions from default roles.
    • Removed correlation storage and synchronization support.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7f4ecbb9-bacb-4c7a-af42-73587b7f99cd

📥 Commits

Reviewing files that changed from the base of the PR and between c018bb7 and 50427d0.

📒 Files selected for processing (12)
  • src/correlation.rs
  • src/handlers/http/correlation.rs
  • src/handlers/http/mod.rs
  • src/handlers/http/modal/mod.rs
  • src/handlers/http/modal/query_server.rs
  • src/handlers/http/modal/server.rs
  • src/handlers/http/users/mod.rs
  • src/lib.rs
  • src/metastore/metastore_traits.rs
  • src/metastore/metastores/object_store_metastore.rs
  • src/prism/home/mod.rs
  • src/rbac/role.rs
💤 Files with no reviewable changes (10)
  • src/handlers/http/users/mod.rs
  • src/handlers/http/modal/server.rs
  • src/handlers/http/modal/query_server.rs
  • src/handlers/http/mod.rs
  • src/correlation.rs
  • src/lib.rs
  • src/metastore/metastore_traits.rs
  • src/rbac/role.rs
  • src/metastore/metastores/object_store_metastore.rs
  • src/handlers/http/correlation.rs

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The pull request removes correlation support from the data model, metastore, HTTP API, startup loading, home search, and RBAC configuration.

Changes

Correlation support removal

Layer / File(s) Summary
Storage contract removal
src/metastore/metastore_traits.rs, src/metastore/metastores/object_store_metastore.rs
The metastore trait and object-store implementation no longer manage correlation data.
HTTP and startup integration removal
src/handlers/http/...
Correlation modules, routes, scopes, startup loading, and the correlation directory constant are removed.
Home search integration removal
src/prism/home/mod.rs
Home search no longer lists correlations or handles correlation-specific errors.
RBAC permission removal
src/rbac/role.rs
Correlation actions are removed from action definitions and default role permissions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 50427

The PR removes correlation-related functionality and has no identified merge-blocking risk at the current head; it is merge-ready after normal checks and review.

Possibly related PRs

Suggested reviewers: parmesant

Poem

A rabbit finds the correlation trail gone,
Storage and routes now move along.
Search skips the old burrow with care,
Permissions leave no carrots there.
The codebase grows quieter at dawn.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required description, rationale, key changes, and checklist are missing. Add a description covering the goal, rationale, key changes, relevant issue reference, and required testing, comments, and documentation checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: removing correlation code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit f881f31 into parseablehq:main Aug 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants