Skip to content

fix(ci): guard release-please's PyPI-publish trigger against the truthy-string bug #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petercorke merged 1 commit into from
Aug 13, 2026
+7 −1
Merged

fix(ci): guard release-please's PyPI-publish trigger against the truthy-string bug #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,14 @@ jobs:
# `pypi` deploy environment's protection rules only allow deploys
# from refs matching `v*` (a tag), so `--ref main` gets rejected at
# the publish step even though build/smoke-test pass.
# release-please-action always sets releases_created to the literal
# string "true"/"false" (core.setOutput stringifies a JS boolean) --
# never unset. In an `if:` expression only "" is falsy, so a bare
# `${{ steps.release.outputs.releases_created }}` is truthy on every
# push, not just when a release was actually created. Must compare
# explicitly against the string 'true'.
- name: Trigger PyPI publish
if: ${{ steps.release.outputs.releases_created }}
if: ${{ steps.release.outputs.releases_created == 'true' }}
run: |
tag=$(gh release list --repo "$GH_REPO" --limit 1 --json tagName -q '.[0].tagName')
gh workflow run release.yml --repo "$GH_REPO" --ref "$tag"
Expand Down