feat: relax opencv pin to support both 4.x and 5.x - #77
Merged
Conversation
pyproject.toml's opencv-python/opencv-contrib-python pin was capped at <5.0.0 since 2026-06-16, defensively, before the codebase actually supported OpenCV 5. PR #61 landed real OpenCV 5 compatibility fixes (aruco, HoughLinesP, BRISK/AKAZE, MSER) and release 2.2.0's changelog already headlined "works under both OpenCV 4 and 5" -- but the pin itself was never relaxed, so pip install could never actually resolve opencv5, and CI never exercised it either. Relax the pin to >=4.5,<6.0.0 per issue #44's plan, and add an opencv-version axis (4, 5) to ci.yml's test matrix so both are actually exercised on every push/PR, not just verified manually once. Verified locally in isolated venvs (not the ambient dev environment): full suite green against real opencv-contrib-python 4.14.0.94 (785 passed, 94 skipped) and 5.0.0.93 (784 passed, 95 skipped). Fixes #44 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.toml'sopencv-python/opencv-contrib-pythonpin was capped at<5.0.0since 2026-06-16, before the codebase actually supported OpenCV 5.pip installcould never actually resolve OpenCV 5, and CI never exercised it.>=4.5,<6.0.0per opencv5 migration: dual-version (4/5) compatibility #44's plan, and adds anopencv-versionaxis (4,5) toci.yml's test matrix so both are exercised on every push/PR going forward.Test plan
opencv-contrib-python4.14.0.94 (785 passed, 94 skipped) and 5.0.0.93 (784 passed, 95 skipped)Fixes #44
🤖 Generated with Claude Code