ci: install open3d on one leg per supported Python version - #81
Merged
Conversation
Completes the remaining part of #46: PR #78 fixed the stale open3d-python package name and added a python_version<3.13 marker, but CI itself never installed open3d, so test_pointcloud.py's and test_bin.py's open3d-guarded coverage kept running skipped/degraded regardless. open3d 0.19.0 ships wheels for cp310-cp312 only (confirmed via PyPI metadata), so install it on ubuntu-latest for python-version 3.10-3.12 (one leg per supported version, opencv-version==5 arbitrarily picked to avoid doubling up -- open3d's behaviour doesn't depend on opencv version). No new matrix axis needed, unlike opencv4-vs-5, since there's no per-OS/version behavioural divergence to hunt for here. Verified locally in an isolated venv: with open3d installed, test_pointcloud.py::test_constructor and test_bin.py's smoke test now genuinely pass (not just unskipped) -- 785 passed/94 skipped vs the 784/95 baseline without open3d, exactly the expected one-test delta, no regressions elsewhere. test_ros.py's open3d-gated pointcloud-publish tests remain skipped in CI -- found during this work that they're also gated behind roslibpy (a separate `ros` extra, also never installed anywhere in CI), which installing open3d alone doesn't unlock. Filed separately as #80 rather than folding into this change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open3d-pythonpackage name and added apython_version<3.13marker, but CI itself never installed open3d, sotest_pointcloud.py's andtest_bin.py's open3d-guarded coverage kept running skipped/degraded regardless of fix: correct stale open3d-python PyPI name, add py3.13 marker #78.ubuntu-latestfor python-version 3.10-3.12, one leg per supported version. No new matrix axis, since (unlike opencv4-vs-5) there's no per-OS/version behavioural divergence in open3d to test for.Test plan
test_pointcloud.py::test_constructorandtest_bin.py's smoke test genuinely pass (785 passed/94 skipped vs 784/95 baseline without open3d — exactly the expected one-test delta), no regressions elsewhereNot fixed here:
test_ros.py's open3d-gated pointcloud-publish tests remain skipped in CI — found they're also gated behindroslibpy(a separaterosextra, also never installed in CI), which open3d alone doesn't unlock. Filed as #80.Fixes #46
🤖 Generated with Claude Code