Skip to content

test: add archiver crash rollback and partitioner FK drop rollback journey stories#45

Open
imtiazqa wants to merge 2 commits into
mainfrom
test/rollback-automation
Open

test: add archiver crash rollback and partitioner FK drop rollback journey stories#45
imtiazqa wants to merge 2 commits into
mainfrom
test/rollback-automation

Conversation

@imtiazqa

@imtiazqa imtiazqa commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Adds two journey stories covering rollback behavior:

Archiver crash rollback — kills the archiver mid Phase 2, asserts data stays in PG, verifies Phase 0 self-heals on re-run
Partitioner FK drop rollback — inbound FK blocks expired partition drop, asserts fail-fast with SQLSTATE 23503 (no retry loop), self-heals after FK reference removed. Skipped in mesh mode with a NOTE.

@imtiazqa imtiazqa requested a review from vyruss as a code owner July 8, 2026 16:20
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 114eb2b9-5812-4398-8d80-db6a34f016b2

📥 Commits

Reviewing files that changed from the base of the PR and between f74749f and 4507e07.

📒 Files selected for processing (1)
  • ci/journey.sh

📝 Walkthrough

Walkthrough

This PR adds two new tiered E2E test stories to ci/journey.sh: story_archiver_rollback, which validates archiver crash recovery and self-healing, and story_partitioner_fk_drop, which validates partitioner failure and self-healing around FK-referenced expired partitions. Both are wired into the tiered execution path.

Changes

Journey script E2E stories

Layer / File(s) Summary
Archiver crash and self-heal story
ci/journey.sh
New story_archiver_rollback function starts the archiver with a debug export delay, kills it mid-run, confirms the row survives in PostgreSQL, then re-runs the archiver and asserts watermark write and unified-view row visibility.
Partitioner FK-drop guard story and wiring
ci/journey.sh
New story_partitioner_fk_drop function verifies the partitioner fails with SQLSTATE 23503 when an FK references an expired partition, then self-heals once the FK row is removed; both new stories are inserted into the tiered orchestration before story_register_cli.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: vyruss

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding archiver crash rollback and partitioner FK drop rollback journey stories.
Description check ✅ Passed The description directly matches the changeset by describing both rollback journey stories and their expected behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/rollback-automation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant