fix: default query_parsers engine to pg_query_protobuf#119
Closed
scottjacobsen wants to merge 1 commit into
Closed
fix: default query_parsers engine to pg_query_protobuf#119scottjacobsen wants to merge 1 commit into
scottjacobsen wants to merge 1 commit into
Conversation
pgdog requires the engine field in [[query_parsers]] entries and fails to start when it is missing, but the chart only rendered engine when set, and documented it as optional. Always render it, defaulting to pg_query_protobuf (pgdog's default engine).
Contributor
|
Ooops. So sure I set a default there. |
Contributor
|
I did not. Let me fix this in pgdog code. We don't want this setting exposed unless absolutely necessary. |
Contributor
|
Fixed in pgdogdev/pgdog#1176 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgdog requires the
enginefield in[[query_parsers]]entries and fails to start when it is missing (theQueryParserconfig struct has no serde default for the field), but the chart only renderedenginewhen set and documented it as optional.Always render
engine, defaulting topg_query_protobuf(pgdog's default engine), so omitting it inqueryParsersvalues no longer produces a config pgdog can't parse.templates/config.yaml: renderengineunconditionally with apg_query_protobufdefaulttest/values-pgdog-config-extras.yaml: add an entry withoutengineto exercise the defaultvalues.yaml: document the defaultVerified with
test/test.sh(all passing) — rendered output:🤖 Generated with Claude Code