Insert splits not behaving properly#1178
Draft
sgrif wants to merge 1 commit into
Draft
Conversation
sgrif
force-pushed
the
sg-insert-split-is-broken
branch
from
3c7b64e to
50e20ae
Compare
When `split_inserts = "error"` is set, we're just ignoring that and incorrectly sending all rows to all shards. When a cross-shard insert is split, we are incorrectly sending the type information for all binds in the original query in the Parse for message for each row The split inserts do not behave transactionally, resulting in a partial insert if one of the rows fails
sgrif
force-pushed
the
sg-insert-split-is-broken
branch
from
50e20ae to
87716ad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
split_inserts = "error"is set, we're just ignoring that andincorrectly sending all rows to all shards.
When a cross-shard insert is split, we are incorrectly sending the type
information for all binds in the original query in the Parse for message
for each row
The split inserts do not behave transactionally, resulting in a partial
insert if one of the rows fails