fix(ui): show short class names with full hover titles, standardize Timeline dots and bars on one blue token, and remove the redundant category legend. - #30
Conversation
…imeline dots and bars on one blue token, and remove the redundant category legend.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1745 1745
===========================================
Files 141 141
Lines 7065 7053 -12
===========================================
- Hits 7065 7053 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
🧰 Additional context used🪛 PHPMD (2.15.0)tests/Panel/Timeline/TimelineRendererTest.php[warning] 18-364: The class TimelineRendererTest has 12 public methods. Consider refactoring TimelineRendererTest to keep number of public methods under 10. (undefined) (TooManyPublicMethods) [error] 102-106: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartKeepsEmptyCategoryFallback'. (undefined) (StaticAccess) [error] 110-110: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartKeepsEmptyCategoryFallback'. (undefined) (StaticAccess) [error] 117-121: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartKeepsMalformedNonEmptyCategoryVisible'. (undefined) (StaticAccess) [error] 125-125: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartKeepsMalformedNonEmptyCategoryVisible'. (undefined) (StaticAccess) [error] 234-238: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartShowsOnlyShortClassNameWithFullCategoryMetadata'. (undefined) (StaticAccess) [error] 240-240: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartShowsOnlyShortClassNameWithFullCategoryMetadata'. (undefined) (StaticAccess) [error] 264-268: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartUsesCategoryOnceWhenItAlreadyHeadsAccessibleLabel'. (undefined) (StaticAccess) [error] 272-272: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartUsesCategoryOnceWhenItAlreadyHeadsAccessibleLabel'. (undefined) (StaticAccess) src/Panel/Timeline/TimelineRenderer.php[error] 24-300: The class TimelineRenderer has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13. (undefined) (CouplingBetweenObjects) [error] 296-296: Avoid using static access to class '\PHPForge\Debug\Helper\Fqcn' in method 'shortCategoryName'. (undefined) (StaticAccess) 📝 SummarySummary by CodeRabbit
WalkthroughThe Timeline renderer now removes the category legend, shows short class names with full category titles, improves accessible labels, and uses one blue color token for dots and bars. Tests and changelog entries reflect the updated markup and styling. ChangesTimeline UI
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR only changes Timeline labels, colors, accessibility metadata, and legend presentation; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request