Skip to content

fix(ui): show short class names with full hover titles, standardize Timeline dots and bars on one blue token, and remove the redundant category legend. - #30

Merged
terabytesoftw merged 1 commit into
mainfrom
fix/profiling-timeline-panel
Sep 3, 2026
Merged

fix(ui): show short class names with full hover titles, standardize Timeline dots and bars on one blue token, and remove the redundant category legend.#30
terabytesoftw merged 1 commit into
mainfrom
fix/profiling-timeline-panel

Conversation

@terabytesoftw

Copy link
Copy Markdown
Contributor

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

…imeline dots and bars on one blue token, and remove the redundant category legend.
@terabytesoftw terabytesoftw added the bug Something isn't working label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bd0d546) to head (217e96d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #30   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1745      1745           
===========================================
  Files            141       141           
  Lines           7065      7053   -12     
===========================================
- Hits            7065      7053   -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 195947d8-e13e-46e8-aaa9-0a0af0499b1e

📥 Commits

Reviewing files that changed from the base of the PR and between bd0d546 and 217e96d.

⛔ Files ignored due to path filters (1)
  • resources/assets/dist/css/debug.min.css is excluded by !**/dist/**, !**/*.min.css
📒 Files selected for processing (5)
  • CHANGELOG.md
  • resources/src/styles/timeline.css
  • src/Panel/Timeline/TimelineRenderer.php
  • src/Panel/Timeline/TimelineSpanRow.php
  • tests/Panel/Timeline/TimelineRendererTest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: quality / YAML (ubuntu-latest)
  • GitHub Check: phpunit / PHP 8.5-windows-2022
  • GitHub Check: phpunit / PHP 8.4-windows-2022
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.3-windows-2022
  • GitHub Check: Verify Vite build reproduces dist.
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: Verify Vite build reproduces dist.
🧰 Additional context used
🪛 PHPMD (2.15.0)
tests/Panel/Timeline/TimelineRendererTest.php

[warning] 18-364: The class TimelineRendererTest has 12 public methods. Consider refactoring TimelineRendererTest to keep number of public methods under 10. (undefined)

(TooManyPublicMethods)


[error] 102-106: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartKeepsEmptyCategoryFallback'. (undefined)

(StaticAccess)


[error] 110-110: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartKeepsEmptyCategoryFallback'. (undefined)

(StaticAccess)


[error] 117-121: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartKeepsMalformedNonEmptyCategoryVisible'. (undefined)

(StaticAccess)


[error] 125-125: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartKeepsMalformedNonEmptyCategoryVisible'. (undefined)

(StaticAccess)


[error] 234-238: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartShowsOnlyShortClassNameWithFullCategoryMetadata'. (undefined)

(StaticAccess)


[error] 240-240: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartShowsOnlyShortClassNameWithFullCategoryMetadata'. (undefined)

(StaticAccess)


[error] 264-268: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineGeometry' in method 'testRenderChartUsesCategoryOnceWhenItAlreadyHeadsAccessibleLabel'. (undefined)

(StaticAccess)


[error] 272-272: Avoid using static access to class '\PHPForge\Debug\Panel\Timeline\TimelineRenderer' in method 'testRenderChartUsesCategoryOnceWhenItAlreadyHeadsAccessibleLabel'. (undefined)

(StaticAccess)

src/Panel/Timeline/TimelineRenderer.php

[error] 24-300: The class TimelineRenderer has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13. (undefined)

(CouplingBetweenObjects)


[error] 296-296: Avoid using static access to class '\PHPForge\Debug\Helper\Fqcn' in method 'shortCategoryName'. (undefined)

(StaticAccess)


📝 Summary

Summary by CodeRabbit

  • UI Improvements

    • Timeline rows now display concise class names, with full category names available on hover.
    • Timeline dots and bars use a consistent blue color.
    • Accessibility labels provide clearer category context without repeating information.
  • Removed

    • Removed the redundant category legend from the Timeline panel.

Walkthrough

The Timeline renderer now removes the category legend, shows short class names with full category titles, improves accessible labels, and uses one blue color token for dots and bars. Tests and changelog entries reflect the updated markup and styling.

Changes

Timeline UI

Layer / File(s) Summary
Timeline renderer behavior
src/Panel/Timeline/TimelineRenderer.php
The renderer removes legend output, adds category-aware aria-label values, and displays short category names with full title metadata.
Timeline visual styling
resources/src/styles/timeline.css, src/Panel/Timeline/TimelineSpanRow.php, CHANGELOG.md
Timeline dots and bars use var(--yii-debug-cat-db). Category row and legend styles are removed. Supporting documentation describes the changes.
Renderer markup validation
tests/Panel/Timeline/TimelineRendererTest.php
Tests cover legend removal, accessible labels, short names, full metadata titles, and empty or malformed categories.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 217e9

This PR only changes Timeline labels, colors, accessibility metadata, and legend presentation; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit hops where Timeline bars gleam
Short names now nest in a title’s sheen
Blue dots march in one steady hue
Legends depart from the panel view
Labels speak clearly, categories stay
Tests guard the trail along the way

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 3 files. (2 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the three main changes: short class names with hover titles, standardized Timeline colors, and legend removal.
Description check ✅ Passed The description identifies the pull request as a non-breaking bug fix, which matches the Timeline UI changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 3 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/profiling-timeline-panel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@terabytesoftw
terabytesoftw merged commit 07b8807 into main Sep 3, 2026
43 checks passed
@terabytesoftw
terabytesoftw deleted the fix/profiling-timeline-panel branch September 3, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant