PHP 8.5 cleanup for ODBC documentation - #4870
Open
NattyNarwhal wants to merge 8 commits into
Open
Conversation
NattyNarwhal
marked this pull request as ready for review
December 2, 2025 15:07
Girgias
reviewed
Jan 9, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
The documentation should still describe behaviour that was possible in PHP 7.
So it might make sense to move all of this to a section "Prior to PHP 8.5" for the flags?
It would also be nice to rewrite the sentences to get rid of personalization (using "you") as that's what our style guide says.
Member
|
With PHP 8.4 But with PHP 8.5 the So I suppose that part of those |
lacatoire
reviewed
Sep 10, 2026
lacatoire
reviewed
Sep 10, 2026
lacatoire
reviewed
Sep 10, 2026
Comment on lines
27
to
33
| dirs. E.g., you should define following for Sybase SQL Anywhere 5.5.00 on | ||
| QNX, prior to run configure script: | ||
| <![CDATA[ | ||
| CPPFLAGS="-DODBC_QNX -DSQLANY_BUG" | ||
| LDFLAGS=-lunix | ||
| CUSTOM_ODBC_LIBS="-ldblib -lodbc". | ||
| ]]> |
lacatoire
requested changes
Sep 10, 2026
This is very ancient and implies a lot of things about PHP database support that hasn't been true in a quarter century. Also invert the guidance to use driver managers instead of linking against drivers directly.
NattyNarwhal
force-pushed
the
odbc-cleanup-8.5
branch
from
September 10, 2026 16:47
bf98155 to
feeffc8
Compare
Moved into a new section. Note that I didn't include Birdstep (dropped in 7.3) or Openlink (dropped seemingly in PHP 5 or older), nor was ODBCRouter ever documented (despite being dropped in 7.3 as well). I can add these if needed.
NattyNarwhal
force-pushed
the
odbc-cleanup-8.5
branch
from
September 10, 2026 17:02
feeffc8 to
d9eaa38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches changes in php/php-src#15727.