ext/reflection: Use canonical spelling and preserve user-given case in error messages#22272
Open
jorgsowa wants to merge 2 commits into
Open
ext/reflection: Use canonical spelling and preserve user-given case in error messages#22272jorgsowa wants to merge 2 commits into
jorgsowa wants to merge 2 commits into
Conversation
jorgsowa
changed the title
When given a "Class::property" argument, getProperty() lowercased the class part before looking it up, so the "Class ... does not exist" exception printed the lowercased name and autoloaders received it in lowercase, breaking case-sensitive (PSR-4) autoloaders. Pass the class name to zend_lookup_class() as given - it lowercases internally for the class-table lookup - matching what ReflectionMethod and ReflectionProperty already do.
jorgsowa
force-pushed
the
canonicalize-error-messages
branch
from
8478dc6 to
c9f5702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #22260
When given a "Class::property" argument,
getProperty()lowercased theclass part before looking it up, so the "Class ... does not exist"
exception printed the lowercased name and autoloaders received it in
lowercase, breaking case-sensitive (PSR-4) autoloaders.
Fixes #22271