ext/standard: add tests for HTTP fopen wrapper - #23557
Open
Sjord wants to merge 4 commits into
Open
Conversation
Girgias
approved these changes
Sep 3, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
More tests make sense, also means the refactoring is more likely to be correct.
Contributor
|
Nice @Sjord! The PR increases coverage by 125 lines and 108 branches. Though, some things were already covered. If we would want to be pedantic we would want to avoid that. But it's more like a nice to have. If you want I can propose something, please let me know. FYI: the last commit sneaked in a space after "# URI parser:", that's the failure. |
Contributor
Author
|
@NickSdot Thanks. It seems that at least ext/standard/tests/http/http_auth_userinfo.phpt does not improve coverage. I'll remove that. Did you have any other tests in mind that should go? |
Sjord
marked this pull request as ready for review
September 4, 2026 10:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.