ext/gd: fix two error messages - #23561
Open
lacatoire wants to merge 3 commits into
Open
Conversation
The message read "must be at between -1 and 100". The sibling writers, imageavif() in particular, use the same bounds without the stray word.
lacatoire
changed the title
NickSdot
reviewed
Sep 4, 2026
Co-authored-by: NickSdot <32384907+NickSdot@users.noreply.github.com>
Member
|
nit: I would rephrase a bit more the PR title , description is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two error messages in
ext/gd/gd.cthat do not say what they mean.imagecolormatch(): the size mismatch message points at "argument #1 ($im1)", a name the function lost in 14a26db when the ext/gd parameters were renamed for 8.0. Both parameters are$image1and$image2.imagejpeg(): an out of range$qualityis rejected with "must be at between -1 and 100".imageavif(), a few lines above in the same file, checks the same bounds and words the message without the stray word. The existing expectation is updated and a test pins the accepted range.Supersedes #23560, which carried the
imagejpeg()half and is now closed.