Fix php://fd/ on platforms without getdtablesize() - #23563
Open
shyim wants to merge 1 commit into
Open
Conversation
HAVE_UNISTD_H does not imply that getdtablesize() exists. Detect the function at configure time and fall back to INT_MAX when it is missing, matching the existing no-unistd path.
TimWolla
reviewed
Sep 4, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
The man page for getdtablesize says:
CONFORMING TO
SVr4, 4.4BSD (the getdtablesize() function first appeared in 4.2BSD). It is not specified in POSIX.1; portable applications should employ sysconf(_SC_OPEN_MAX) instead of this call.
Should we use _SC_OPEN_MAX instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HAVE_UNISTD_H does not imply that getdtablesize() exists. Detect the function at configure time.