Skip to content

Code quality batch#64

Merged
luispabon merged 10 commits into
masterfrom
cl/2026-06-17_code-quality-batch
Jun 17, 2026
Merged

Code quality batch#64
luispabon merged 10 commits into
masterfrom
cl/2026-06-17_code-quality-batch

Conversation

@luispabon

@luispabon luispabon commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add graceful SIGINT/SIGTERM shutdown and run the container under tini.
  • Add flat ESLint config and wire lint scripts to run ESLint plus Prettier.
  • Split the large app test file into focused suites with shared helpers and added coverage for validation, fetch errors, redirects, security, parsing, markdown, config, and concurrency.
  • Move release publishing to package.json-backed vX.Y.Z tags, with Docker image publishing and GitHub Release creation in the tag workflow.
  • Restrict Node test discovery to test/*.test.js so helper files are not executed as empty suites.
  • Remove planning artifacts after successful review.

Review

Final review status: pass. No blocking or non-blocking findings remained.

Verification

  • PNPM_CONFIG_MINIMUM_RELEASE_AGE=0 npx pnpm@11.7.0 lint
  • PNPM_CONFIG_MINIMUM_RELEASE_AGE=0 npx pnpm@11.7.0 test
  • docker build -t readability-js .
  • Container SIGTERM shutdown probe, exit status 0

Residual Risk

  • The GitHub release workflow metadata logic was simulated locally, but the workflow has not been exercised by pushing a real release tag in this review.

Closes #62
Closes #61
Closes #60
Closes #55

Comment thread test/helpers.js Fixed
@luispabon luispabon merged commit 8fc7923 into master Jun 17, 2026
3 checks passed
@luispabon luispabon deleted the cl/2026-06-17_code-quality-batch branch June 17, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants