fix: isolate JSDOM parsing in child process to prevent memory leak#67
Merged
Conversation
JSDOM leaks ~1.6MB of non-GC-able memory per window/document creation. Over thousands of requests this caused multi-GB RSS growth. The leak is fundamental to JSDOM's C++ internals — window.close() and forced GC cannot reclaim it. Move all JSDOM/Readability/DOMPurify work into a child process that self-recycles every 500 parses. On termination the OS reclaims all leaked memory. Main process RSS stays flat at ~125MB regardless of request volume (verified at 10K requests, 0 failures). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Closes #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSDOM leaks ~1.6MB of non-GC-able memory per window/document creation. Over thousands of requests this caused multi-GB RSS growth. The leak is fundamental to JSDOM's C++ internals — window.close() and forced GC cannot reclaim it.
Move all JSDOM/Readability/DOMPurify work into a child process that self-recycles every 500 parses. On termination the OS reclaims all leaked memory. Main process RSS stays flat at ~125MB regardless of request volume (verified at 10K requests, 0 failures).