Conversation
PHP accepts class names with a leading backslash ('\Foo\Bar'), but the object types built from constant strings kept it: the resulting types were described as \Foo\Bar and didn't match the ones built from Foo\Bar::class.
Extensions looking the class name up elsewhere were affected too: for example phpstan-doctrine couldn't find the entity metadata of $entityManager->getRepository('\Foo\Bar'), so the magic findByXxx() methods of the repository were reported as undefined.
Strip the leading backslash when turning a constant string into an object type: in ConstantStringType (class-string object type, instanceof and is_a() checks, class constants), GenericClassStringType (accepts, isSuperTypeOf, template type inference, type removal) and ImpossibleCheckTypeHelper (method_exists()).
Collaborator
|
You've opened the pull request against the latest branch 2.3.x. PHPStan 2.3 is not going to be released for months. If your code is relevant on 2.2.x and you want it to be released sooner, please rebase your pull request and change its target to 2.2.x. |
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP accepts class names with a leading backslash (
'\Foo\Bar'), but the object types built from constant strings kept it: the resulting types were described as\Foo\Barand didn't match the ones built fromFoo\Bar::class.Extensions looking the class name up elsewhere were affected too: for example phpstan-doctrine couldn't find the entity metadata of
$entityManager->getRepository('\Foo\Bar'), so the magicfindByXxx()methods of the repository were reported as undefined.Strip the leading backslash when turning a constant string into an object type: in
ConstantStringType(class-stringobject type,instanceofandis_a()checks, class constants),GenericClassStringType(accepts,isSuperTypeOf, template type inference, type removal) andImpossibleCheckTypeHelper(method_exists()).