Skip to content

Exclude phpstorm-stubs test suite from function metadata generation #6439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into from
Sep 14, 2026
+8 −7
Merged

Exclude phpstorm-stubs test suite from function metadata generation #6439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/functionMetadata_original.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@
'ob_get_clean' => ['hasSideEffects' => true],
'ob_get_contents' => ['hasSideEffects' => true],
'ob_get_length' => ['hasSideEffects' => true],
'ob_get_level' => ['hasSideEffects' => true],
'ob_get_level' => ['hasSideEffects' => false],
'ob_get_status' => ['hasSideEffects' => true],
'ob_list_handlers' => ['hasSideEffects' => true],
'output_add_rewrite_var' => ['hasSideEffects' => true],
Expand Down
9 changes: 7 additions & 2 deletions bin/generate-function-metadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

$parser = (new ParserFactory())->createForNewestSupportedVersion();
$finder = new Finder();
$finder->in(__DIR__ . '/../vendor/jetbrains/phpstorm-stubs')->files()->name('*.php');
$finder->in(__DIR__ . '/../vendor/jetbrains/phpstorm-stubs')->exclude('tests')->files()->name('*.php');

$visitor = new class() extends NodeVisitorAbstract {

Expand Down Expand Up @@ -69,6 +69,7 @@ public function enterNode(Node $node)
'function_exists',
'json_last_error',
'json_last_error_msg',
'ob_get_level',
], true)) {
$this->functions[] = $functionName;
break 2;
Expand All @@ -91,6 +92,10 @@ public function enterNode(Node $node)
if (!$class instanceof Node\Stmt\ClassLike) {
throw new ShouldNotHappenException($node->name->toString());
}
if (!isset($class->namespacedName)) {
// anonymous class
return null;
}
$className = $class->namespacedName->toString();
foreach ($node->attrGroups as $attrGroup) {
foreach ($attrGroup->attrs as $attr) {
Expand Down Expand Up @@ -229,5 +234,5 @@ public function enterNode(Node $node)
);
}

FileWriter::write(__DIR__ . '/../resources/functionMetadata.php', sprintf($template, $content));
FileWriter::write(__DIR__ . '/../resources/functionMetadata.php', sprintf($template, $content) . "\n");
})();
4 changes: 0 additions & 4 deletions resources/functionMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,10 +676,6 @@
'Spoofchecker::__construct' => ['hasSideEffects' => false],
'StringBackedEnum::from' => ['hasSideEffects' => false],
'StringBackedEnum::tryFrom' => ['hasSideEffects' => false],
'StubTests\\CodeStyle\\BracesOneLineFixer::getDefinition' => ['hasSideEffects' => false],
'StubTests\\Parsers\\ExpectedFunctionArgumentsInfo::__toString' => ['hasSideEffects' => false],
'StubTests\\StubsMetaExpectedArgumentsTest::getClassMemberFqn' => ['hasSideEffects' => false],
'StubTests\\StubsParameterNamesTest::printParameters' => ['hasSideEffects' => false],
'Transliterator::createInverse' => ['hasSideEffects' => false],
'Transliterator::getErrorCode' => ['hasSideEffects' => false],
'Transliterator::getErrorMessage' => ['hasSideEffects' => false],
Expand Down
Loading