[diffs/edit] Add edit prediction support - #1024
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@codex review again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dae253f656
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Cross-line edits cannot share their boundary line with another | ||
| // preview overlay. | ||
| if (renderEdits.at(-1)?.range.end.line === line) { | ||
| return; |
There was a problem hiding this comment.
Support valid edits that share a boundary line
When one non-overlapping edit crosses into a line and the next edit starts later on that same line—for example, {0,2}->{1,0} followed by {1,1}->{1,2}—the previous render edit ends on line, so this branch returns from the response handler. The public provider contract permits non-overlapping edit batches, but this valid response is silently discarded: no preview appears and Tab cannot accept it. Compose the boundary-line overlays or otherwise render the batch without rejecting it.
Useful? React with 👍 / 👎.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@ije can you add an example to the playground for this as well? that way we can make sure it works with virtualization libraries, etc |
Screen.Recording.2026-07-25.at.02.18.26.mov
Usage: