Skip to content

fix(web): match create theme and import theme buttons to the standard outline style - #5860

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/web/theme-buttons-consistent-style
Aug 9, 2026
Merged

fix(web): match create theme and import theme buttons to the standard outline style#5860
maria-rcks merged 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/web/theme-buttons-consistent-style

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

What Changed

Changed both theme buttons on Settings > Appearance to use the standard settings outline style. Previously, "Create theme" had a custom chip-like style (extra padding, muted background, custom border) and "Import theme" was a bare ghost button. Now both use the same size="xs" variant="outline" look as every other button on the Settings pages.

Why

The styling was inconsistent.

  1. Both buttons looked different from each other.
  2. "Create theme" button had a custom style different from all others, and hence looked different. The custom style also pinned a fixed height and padding at all screen sizes, while the standard buttons shrink on smaller screens.
  3. "Import theme" had the ghost variant, which is used for icon-only buttons or buttons with less importance.

Removing the overrides makes the row match the rest of Settings and fixes the sizing behavior.

UI Changes

Before:
image

After:
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Note

Low Risk
Cosmetic button styling only in theme settings; no logic or data changes.

Overview
Appearance > Themes row buttons are aligned with the rest of Settings.

Create theme drops its custom chip styling (fixed height, muted background, extra border/padding) and uses size="xs" with variant="outline". Import theme switches from ghost to the same outline variant. Behavior and click handlers are unchanged.

Reviewed by Cursor Bugbot for commit d7f3572. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Match 'Create theme' and 'Import theme' buttons to outline style in ThemeSettings

Changes the variant of both buttons in ThemeSettings.tsx from ghost to outline for visual consistency. Also removes the custom className previously applied to the 'Create theme' button.

Macroscope summarized d7f3572.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0fd15d4b-33ce-4053-aa9c-cd997bbf046b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved d7f3572

This is a purely cosmetic change that updates two button variants from 'ghost' to 'outline' and removes redundant custom styling. No runtime behavior is affected - only visual appearance for UI consistency.

You can customize Macroscope's approvability policy. Learn more.

@UtkarshUsername UtkarshUsername changed the title fix(web): match create/import theme buttons to the standard outline style fix(web): match create theme and import theme buttons to the standard outline style Aug 9, 2026
@maria-rcks

Copy link
Copy Markdown
Collaborator

why not go the other way... borderless?

@maria-rcks
maria-rcks merged commit 02f4ce5 into pingdotgg:main Aug 9, 2026
17 checks passed
@UtkarshUsername

Copy link
Copy Markdown
Contributor Author

@maria-rcks That's what I initially wanted to do, but then I saw that most other buttons in settings have this style

github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 9, 2026
## What's Changed
* fix(web): preserve desktop route during Clerk auth by @wobsoriano in pingdotgg/t3code#5770
* fix(web): match create theme and import theme buttons to the standard outline style by @UtkarshUsername in pingdotgg/t3code#5860

## New Contributors
* @wobsoriano made their first contribution in pingdotgg/t3code#5770

**Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260809.1043...v0.0.33-nightly.20260809.1045

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260809.1045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants