fix(web): match create theme and import theme buttons to the standard outline style - #5860
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved d7f3572 This is a purely cosmetic change that updates two button variants from 'ghost' to 'outline' and removes redundant custom styling. No runtime behavior is affected - only visual appearance for UI consistency. You can customize Macroscope's approvability policy. Learn more. |
|
why not go the other way... borderless? |
|
@maria-rcks That's what I initially wanted to do, but then I saw that most other buttons in settings have this style |
## What's Changed * fix(web): preserve desktop route during Clerk auth by @wobsoriano in pingdotgg/t3code#5770 * fix(web): match create theme and import theme buttons to the standard outline style by @UtkarshUsername in pingdotgg/t3code#5860 ## New Contributors * @wobsoriano made their first contribution in pingdotgg/t3code#5770 **Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260809.1043...v0.0.33-nightly.20260809.1045 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260809.1045
What Changed
Changed both theme buttons on Settings > Appearance to use the standard settings outline style. Previously, "Create theme" had a custom chip-like style (extra padding, muted background, custom border) and "Import theme" was a bare ghost button. Now both use the same size="xs" variant="outline" look as every other button on the Settings pages.
Why
The styling was inconsistent.
Removing the overrides makes the row match the rest of Settings and fixes the sizing behavior.
UI Changes
Before:

After:

Checklist
Note
Low Risk
Cosmetic button styling only in theme settings; no logic or data changes.
Overview
Appearance > Themes row buttons are aligned with the rest of Settings.
Create theme drops its custom chip styling (fixed height, muted background, extra border/padding) and uses
size="xs"withvariant="outline". Import theme switches fromghostto the same outline variant. Behavior and click handlers are unchanged.Reviewed by Cursor Bugbot for commit d7f3572. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Match 'Create theme' and 'Import theme' buttons to outline style in ThemeSettings
Changes the variant of both buttons in ThemeSettings.tsx from
ghosttooutlinefor visual consistency. Also removes the customclassNamepreviously applied to the 'Create theme' button.Macroscope summarized d7f3572.