fix: correct date axis timezone in hoveranywhere/clickanywhere events#7818
Open
godfengliang wants to merge 1 commit into
Open
fix: correct date axis timezone in hoveranywhere/clickanywhere events#7818godfengliang wants to merge 1 commit into
godfengliang wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR! Our team is taking a look at this area of the code, so we'll review your PR in tandem and follow up with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7816.
For date axes, p2c returns a display-time value (local-time components encoded as UTC ms). This caused hoveranywhere and clickanywhere events to report timestamps shifted by the local timezone offset.
Fix: after p2c for date axes, apply timezone correction to convert back to true UTC ms.