Skip to content

Fix(Migration): prevent container name corruption on partial update #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stonebuzz wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −1
Open

Fix(Migration): prevent container name corruption on partial update #1225

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
277dc3a
Fix(Migration): prevent container name corruption on partial update
stonebuzz Jul 13, 2026
56010a8
Update inc/container.class.php
stonebuzz Jul 13, 2026
adc12e9
fix CS
stonebuzz Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion inc/container.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@
$update_data = [
'id' => $container['id'],
'itemtypes' => $itemtypes,
'label' => $container['label'],
];
if ($container_name !== $container['name']) {
$update_data['name'] = $container_name;
Expand Down Expand Up @@ -648,7 +649,12 @@

public function prepareInputForUpdate($input)
{
return PluginFieldsToolbox::prepareLabel($input);
// if label not empty, prepare name from label
if (isset($input['label']) && !empty($input['label'])) {
$input['label'] = PluginFieldsToolbox::sanitizeLabel((string) ($input['label'] ?? ''));

Check failure on line 654 in inc/container.class.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.2 - mariadb:10.6 / Continuous integration 

Offset 'label' on non-empty-array<string, mixed> on left side of ?? always exists and is not nullable.

Check failure on line 654 in inc/container.class.php

View workflow job for this annotation

GitHub Actions / GLPI 11.0.x - php:8.5 - mariadb:11.8 / Continuous integration 

Offset 'label' on non-empty-array<string, mixed> on left side of ?? always exists and is not nullable.
}
Comment thread
stonebuzz marked this conversation as resolved.

return $input;
}

public function prepareInputForAdd($input)
Expand Down
Loading