fix(typescript): use Decimal.js for exact slippage validation#1709
Open
AbhilashG12 wants to merge 1 commit into
Open
fix(typescript): use Decimal.js for exact slippage validation#1709AbhilashG12 wants to merge 1 commit into
AbhilashG12 wants to merge 1 commit into
Conversation
- Replace floating-point math with Decimal for worst_price validation - Use exact arithmetic to match Python SDK's behavior - Prevents IEEE-754 rounding issues at slippage boundaries - Add tests for Decimal validation Fixes pmxt-dev#1504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes SDK drift between TypeScript and Python for hosted-mode economic validation.
The Problem
TypeScript uses floating-point math (
number), Python uses exact math (Decimal). This means near a slippage boundary, the two SDKs can disagree on whether a signature is valid.The Fix
number(floating-point)Decimal(exact)Decimal(exact)Decimal(exact) ✅Changes
decimal.jsdependency to TypeScript SDKvalidateWorstPriceWhy It Matters
This is a security-critical validator that guards against compromised servers returning altered economics. Both SDKs must agree on the same validation logic.
Fixes #1504