fix: Remove extra closing PHP tag from highlight_code() on PHP 8.3+ Fix #51. - #54
Open
ajdunn2 wants to merge 1 commit into
Open
fix: Remove extra closing PHP tag from highlight_code() on PHP 8.3+ Fix #51.#54ajdunn2 wants to merge 1 commit into
ajdunn2 wants to merge 1 commit into
Conversation
pocketarc#51. Handle the HTML format introduced in PHP 8.3 when removing the injected closing tag. Keep support for older PHP versions and add a regression test for profiler queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.3 changed the HTML returned by highlight_string(), so highlight_code() stopped removing the closing ?> it adds internally. This left a stray ?> at the end of queries in the profiler.
This updates the existing regex to handle both HTML formats, keeping compatibility with older PHP versions. It also fixes the test that expected the duplicate closing tag and adds coverage for a query without PHP tags.