fix: Add create_sid() to CI_SessionWrapper for PHP 8.6 compatibility - #55
Open
ajdunn2 wants to merge 1 commit into
Open
fix: Add create_sid() to CI_SessionWrapper for PHP 8.6 compatibility#55ajdunn2 wants to merge 1 commit into
ajdunn2 wants to merge 1 commit into
Conversation
PHP 8.6 deprecates session save handlers implementing SessionHandlerInterface without a create_sid() method, ahead of making it required in PHP 9.0. Add create_sid(): string to CI_SessionWrapper delegating to session_create_id(). This hook has been supported since PHP 7.1 and maintains identical behavior on PHP 8.0-8.5 while clearing the PHP 8.6 deprecation. Verified across PHP 8.0, 8.1, 8.2, 8.3, 8.4, 8.5, and 8.6 beta 2: - New session start and existing session resumption - session_regenerate_id() and session_regenerate_id(true) - Explicit session_create_id() calls - Zero warnings or deprecations on PHP 8.0-8.5; PHP 8.6 warning cleared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6 deprecates session save handlers that implement
SessionHandlerInterfacewithout acreate_sid()method. The method will be required in PHP 9.0.Add
create_sid(): stringtoCI_SessionWrapper, delegating tosession_create_id()to clear the deprecation. The method has been supported as an optional hook since PHP 7.1 and is a no-op on earlier versions, adding it shouldn't change behaviour on PHP 8.0 - 8.5, it just clears the 8.6 deprecation ahead of the 9.0 requirement.Verified on PHP 8.0 - 8.5 and 8.6 beta 2:
session_regenerate_id()andsession_regenerate_id(true)session_create_id()calls