PG 19 and regression test fixes#60
Open
devrimgunduz wants to merge 2 commits into
Open
Conversation
PostgreSQL 19 introduced several changes that broke the jsquery build and surfaced new warnings: * pushJsonbValue() now takes a pointer to a caller-provided, zero-initialized JsonbInState instead of a JsonbParseState pointer, and returns void. The completed JsonbValue is now available in JsonbInState.result once the outermost container is closed. Add a jsqPushJsonbValue() wrapper and a JsQueryJsonbState typedef in jsquery_op.c (guarded with #if PG_VERSION_NUM >= 190000) so that the result-accumulation code works on all supported versions. * Extensions are now built with -Wimplicit-fallthrough=5, where "fall through" comments are ignored and only the fallthrough attribute suppresses the warning. Replace the comments with pg_fallthrough (provided by c.h as of PostgreSQL 19) and add a fallback definition to jsquery.h for older server versions. Coded by Claude, tested by me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR includes fixes for both PostgreSQL 19 compatibility and also fixes for regression tests.
Per: pgdg-packaging/pgdg-rpms#213
C code hacked by Claude, regression tests hacked by me. Tests passed on my F44 box.
Regards, Devrim