fix: Mistakes in os_ops::create_clone implementations (local and remote)#106
Merged
dmitry-lipetsk merged 1 commit intoJul 9, 2026
Conversation
1) LocalOperations::create_clone did not copy "_port" member. 2) RemoteOperations::create_clone did not create "_remote_env_guard" and did not clone "_remote_env". It was fixed. Ofcourse test_create_clone is updated, too. Also - This commit adds use_clone fixture.
dmitry-lipetsk
force-pushed
the
D20260709_002--os_ops-create_clone-is-fixed
branch
from
461d541 to
a977788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mistakes
LocalOperations::create_clonedid not copy "_port" member.RemoteOperations::create_clonedid not create "_remote_env_guard" and did not clone "_remote_env".It was fixed.
Ofcourse
test_create_cloneis updated, too.Also
use_clonefixture.