OsOperations::set_env is corrected#97
Merged
dmitry-lipetsk merged 2 commits intoJul 8, 2026
Merged
Conversation
Declaration:
def set_env(
self,
var_name: str,
var_val: typing.Optional[str],
) -> None:
LocalOperations:
- deletes variable when value is None via 'os.environ.pop(var_name, None)'
RemoteOperations:
- [add] T_ENVS
- [add] _remote_env
- [add] _remote_env_guard
- exec_command processes self._remote_env
- environ uses an absolte path /usr/bin/printenv
- set_env saves new value into self._remote_env
Two new tests:
- test_set_env__persistence
- test_set_env__evil
Co-authored-by: Mark G. <mark@google.com>
9354472 to
4ce9a7f
Compare
Alpne holds it in /bin/printenv. So, we will use printenv. Test is corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaration:
LocalOperations:
RemoteOperations:
Two new tests: