Skip to content

Process the exception if pg_config is not found #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asavchkov wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Process the exception if pg_config is not found #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,12 @@ def cache_pg_config_data(cmd):
return cache_pg_config_data(cmd)

# try plain name
return cache_pg_config_data("pg_config")
try:
pg_config_data = cache_pg_config_data("pg_config")
except Exception:
raise Exception(

@dmitry-lipetsk dmitry-lipetsk Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В testgres есть свои исключения - TestgresException, InvalidOperationError.

Наверное лучше будет выкидывать InvalidOperationError, потому что TestgresException везде юзается как базовый класс и вроде в чистом виде нигде не выкидывается.

"Failed to determine how to start pg_config. Specify the path to pg_config in PG_CONFIG or the path to the Postgres directory containing it in PG_BIN, or put it into the system PATH.")
return pg_config_data


def get_pg_version2(os_ops: OsOperations, bin_dir=None):
Expand Down