fix(scipy): support v1.18.1 and future versions via wildcard fallback - #8681
Open
pjsharath28 wants to merge 2 commits into
Open
fix(scipy): support v1.18.1 and future versions via wildcard fallback#8681pjsharath28 wants to merge 2 commits into
pjsharath28 wants to merge 2 commits into
Conversation
Author
|
@afsanjar, scipy 1.8.1 is blocked by this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
"*"wildcard entry inbuild_info.jsonpointing toscipy_v1.18.0_ubi_9.6.shso any version without an explicit key resolves to the latest build scriptscipy_v1.18.0_ubi_9.6.sh: remove quotes from the heredoc opening delimiter (<< 'PYEOF'→<< PYEOF) so the shell expands${PACKAGE_VERSION#v}dynamically before passing it to PythonRoot Cause
Currency build for
v1.18.1was failing because:"*"wildcard fallback inbuild_info.json(silently fell back to top-levelbuild_script, which happened to be correct but is implicit)<< 'PYEOF'(single-quoted), which suppresses all shell expansion inside the block —${PACKAGE_VERSION#v}was passed as a literal string to Python instead of the actual version value, causing the assertion to always fail for any version other than1.18.0Checklist
set -eoption enabled and observe success ?