Skip to content

fix(scipy): support v1.18.1 and future versions via wildcard fallback - #8681

Open
pjsharath28 wants to merge 2 commits into
ppc64le:masterfrom
afsanjar:fix/scipy-v1.18.1-support
Open

fix(scipy): support v1.18.1 and future versions via wildcard fallback#8681
pjsharath28 wants to merge 2 commits into
ppc64le:masterfrom
afsanjar:fix/scipy-v1.18.1-support

Conversation

@pjsharath28

Copy link
Copy Markdown

Changes

  • Add "*" wildcard entry in build_info.json pointing to scipy_v1.18.0_ubi_9.6.sh so any version without an explicit key resolves to the latest build script
  • Fix version assertion in scipy_v1.18.0_ubi_9.6.sh: remove quotes from the heredoc opening delimiter (<< 'PYEOF'<< PYEOF) so the shell expands ${PACKAGE_VERSION#v} dynamically before passing it to Python

Root Cause

Currency build for v1.18.1 was failing because:

  1. No "*" wildcard fallback in build_info.json (silently fell back to top-level build_script, which happened to be correct but is implicit)
  2. The heredoc used << 'PYEOF' (single-quoted), which suppresses all shell expansion inside the block — ${PACKAGE_VERSION#v} was passed as a literal string to Python instead of the actual version value, causing the assertion to always fail for any version other than 1.18.0

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@pjsharath28

Copy link
Copy Markdown
Author

@afsanjar, scipy 1.8.1 is blocked by this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant