New adapter: HypeLab#4488
Open
Minebomber wants to merge 3 commits into
Open
Conversation
CTMBNara
requested changes
May 13, 2026
Author
|
Thanks for the feedback, I made an update based off of your review @CTMBNara |
CTMBNara
requested changes
May 19, 2026
Author
|
Thanks for helping me work through this @CTMBNara. I pushed a patch for your requested changes. |
Collaborator
|
@Minebomber currently, PBS is on hold for adapter merges. The main focus is the next major update, 4.0, which should be finished by the end of Q2. Once that is done, we should be unblocked for merging other PRs. Sorry for the inconvenience. |
CTMBNara
requested changes
Jun 15, 2026
| .toList(); | ||
| } | ||
|
|
||
| private static BidderBid makeBidderBid(Bid bid, String seat, Map<String, Imp> impIdToImp, String currency, |
Collaborator
There was a problem hiding this comment.
private static BidderBid makeBidderBid(Bid bid,
String seat,
Map<String, Imp> impIdToImp,
String currency,
List<BidderError> errors) {
Comment on lines
+73
to
+75
| final BidRequest bidRequest = givenBidRequestWithExt(requestExt, | ||
| imp -> imp.id("imp1").banner(Banner.builder().w(300).h(250).build()) | ||
| .ext(givenImpExt("property", "placement"))); |
Collaborator
There was a problem hiding this comment.
final BidRequest bidRequest = givenBidRequestWithExt(
requestExt,
imp -> imp
.id("imp1")
.banner(Banner.builder().w(300).h(250).build())
.ext(givenImpExt("property", "placement")));
Comment on lines
+88
to
+93
| assertThat(request.getMethod()).isEqualTo(HttpMethod.POST); | ||
| assertThat(request.getUri()).isEqualTo(ENDPOINT_URL); | ||
| assertThat(request.getImpIds()).containsExactly("imp1"); | ||
| assertThat(request.getHeaders().get(HttpUtil.ACCEPT_HEADER)).isEqualTo("application/json"); | ||
| assertThat(request.getHeaders().get(HttpUtil.CONTENT_TYPE_HEADER)) | ||
| .isEqualTo("application/json;charset=utf-8"); |
Collaborator
There was a problem hiding this comment.
No need to check this properties
Comment on lines
+96
to
+109
| assertThat(imp.getTagid()).isEqualTo("placement"); | ||
| assertThat(imp.getDisplaymanager()).isEqualTo("HypeLab Prebid Server"); | ||
| assertThat(imp.getDisplaymanagerver()).isEqualTo(PBS_VERSION); | ||
| assertThat(imp.getExt()).isEqualTo(mapper.valueToTree( | ||
| ExtPrebid.of(null, ExtImpHypeLab.of("property", "placement")))); | ||
|
|
||
| assertThat(payload.getExt()).isNotSameAs(requestExt); | ||
| assertThat(payload.getExt().getProperty("existing")).isEqualTo(existingExt).isNotSameAs(existingExt); | ||
| assertThat(payload.getExt().getProperty("source")).isEqualTo(mapper.valueToTree("prebid-server")); | ||
| assertThat(payload.getExt().getProperty("provider_version")) | ||
| .isEqualTo(mapper.valueToTree("prebid-server@" + PBS_VERSION)); | ||
| assertThat(requestExt.getProperty("source")).isNull(); | ||
| assertThat(requestExt.getProperty("provider_version")).isNull(); | ||
| assertThat(jacksonMapper.decodeValue(request.getBody(), BidRequest.class)).isEqualTo(payload); |
Collaborator
There was a problem hiding this comment.
Split into multiple tests
| final BidRequest payload = result.getValue().getFirst().getPayload(); | ||
|
|
||
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(payload.getImp().getFirst().getDisplaymanagerver()).isEqualTo("unknown"); |
Collaborator
There was a problem hiding this comment.
Use same approach for all assertions:
assertThat(result.getValue())
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getDisplaymanagerver)
.containsExactly("unknown")
Comment on lines
+321
to
+323
| final List<Imp> imps = impCustomizers.length == 0 | ||
| ? singletonList(givenImp(UnaryOperator.identity())) | ||
| : Arrays.stream(impCustomizers) |
Collaborator
There was a problem hiding this comment.
Remove logic with length == 0 and always provide imp
| return givenBidRequestWithExt(null, impCustomizers); | ||
| } | ||
|
|
||
| private static BidRequest givenBidRequestWithExt(ExtRequest ext, UnaryOperator<Imp.ImpBuilder>... impCustomizers) { |
Collaborator
There was a problem hiding this comment.
UnaryOperator<Imp.ImpBuilder>... impCustomizers -> Imp.. imps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
This PR adds the HypeLab bid adapter to Prebid Server Java.
The adapter supports site banner, native, and video inventory. It accepts
property_slugandplacement_slugbidder params, forwards eligible OpenRTB 2.6 requests to HypeLab, adds HypeLab display manager metadata, and maps HypeLab bid responses back into Prebid bid types.🧠 Rationale behind the change
HypeLab needs a dedicated adapter because the request is not just a raw OpenRTB pass-through. The adapter validates required bidder params, sets
tagidfromplacement_slug, preserves the HypeLab bidder ext, adds provider metadata, and resolves response bid type frommtype,ext.hypelab.creative_type, VAST markup, or the original impression media type.🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
/openrtb2/auctionpath and HypeLab adapter configuration../mvnw -Dtest=HypeLabBidderTest testsuccessfully.HypeLabBidder: 96% instruction coverage and 97% line coverage.🏎 Quality check