feat: support video, native, and audio media types in ConnectAd Adapter#4506
Open
rtuschkany wants to merge 3 commits into
Open
feat: support video, native, and audio media types in ConnectAd Adapter#4506rtuschkany wants to merge 3 commits into
rtuschkany wants to merge 3 commits into
Conversation
…ropagate network/site IDs in imp extension
Co-authored-by: Cursor <cursoragent@cursor.com>
CTMBNara
requested changes
Jun 15, 2026
Comment on lines
+62
to
+64
| if (imp.getBanner() == null && imp.getVideo() == null && imp.getXNative() == null && imp.getAudio() == null) { | ||
| throw new PreBidException("We need a Banner, Video, Native or Audio Object in the request"); | ||
| } |
Collaborator
There was a problem hiding this comment.
No need for this validation
| }; | ||
| } | ||
|
|
||
| if (bidRequest != null && CollectionUtils.isNotEmpty(bidRequest.getImp())) { |
Collaborator
There was a problem hiding this comment.
bidRequest can't be null.
bidRequest.getImp() can't be empty
| .build(); | ||
| } | ||
|
|
||
| private ObjectNode modifyImpExt(ObjectNode impExt, ExtImpConnectAd extImpConnectAd) { |
Collaborator
There was a problem hiding this comment.
Reorder methods, so they are in call order
| } | ||
|
|
||
| private ObjectNode modifyImpExt(ObjectNode impExt, ExtImpConnectAd extImpConnectAd) { | ||
| final ObjectNode modifiedExt = impExt != null ? impExt.deepCopy() : mapper.mapper().createObjectNode(); |
Comment on lines
+124
to
+141
| if (networkId != null) { | ||
| try { | ||
| modifiedExt.put("networkId", Integer.parseInt(networkId)); | ||
| } catch (NumberFormatException e) { | ||
| modifiedExt.put("networkId", networkId); | ||
| } | ||
| } | ||
|
|
||
| if (siteId != null) { | ||
| try { | ||
| modifiedExt.put("siteId", Integer.parseInt(siteId)); | ||
| } catch (NumberFormatException e) { | ||
| modifiedExt.put("siteId", siteId); | ||
| } | ||
| } | ||
|
|
||
| return modifiedExt; | ||
| } |
Collaborator
There was a problem hiding this comment.
Why do you need this? This fields already present in initial impExt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ropagate network/site IDs in imp extension
🔧 Type of changes