New Adapter: BidWave#4523
Open
eng-bidwave wants to merge 1 commit into
Open
Conversation
3 tasks
eng-bidwave
force-pushed
the
bidwave-adapter
branch
from
118834f to
4b15ded
Compare
CTMBNara
requested changes
Jun 15, 2026
| private static final String BIDWAVE_EXT = "bidwave"; | ||
| private static final String PUBLISHER_ID_EXT = "pid"; | ||
| private static final String BIDDER_CURRENCY = "USD"; | ||
| private static final List<String> DEFAULT_CURRENCY = List.of(BIDDER_CURRENCY); |
Collaborator
There was a problem hiding this comment.
List.of -> Collections.singletonList
| .formatted(imp.getId(), e.getMessage())); | ||
| } | ||
|
|
||
| final String publisherId = extImpBidwave != null ? extImpBidwave.getPublisherId() : null; |
Collaborator
There was a problem hiding this comment.
extImpBidwave can't be null
| private ExtRequest createRequestExt(ExtRequest requestExt, String publisherId) { | ||
| final ExtRequest updatedExt = ExtRequest.of(requestExt != null ? requestExt.getPrebid() : null); | ||
| if (requestExt != null) { | ||
| updatedExt.addProperties(requestExt.getProperties()); |
Collaborator
There was a problem hiding this comment.
mapper.fillExtension(updatedExt, requestExt)
|
|
||
| private static List<BidderBid> extractBids(BidRequest bidRequest, BidResponse bidResponse, | ||
| List<BidderError> errors) { | ||
| if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) { |
Collaborator
There was a problem hiding this comment.
private static List<BidderBid> extractBids(BidRequest bidRequest,
BidResponse bidResponse,
List<BidderError> errors) {
if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) {
Comment on lines
+184
to
+186
| private static BidderBid makeBidderBid(Bid bid, Map<String, Imp> impsById, String currency, | ||
| List<BidderError> errors) { | ||
| final BidType bidType; |
Collaborator
There was a problem hiding this comment.
private static BidderBid makeBidderBid(Bid bid,
Map<String, Imp> impsById,
String currency,
List<BidderError> errors) {
final BidType bidType;
| } | ||
|
|
||
| @Test | ||
| public void makeHttpRequestsShouldSetBidwaveExtDefaultCurrencyAndPreserveDeviceGeo() |
| } | ||
|
|
||
| @Test | ||
| public void makeHttpRequestsShouldGroupImpsByPublisherIdAndNormalizeCurrency() { |
Collaborator
There was a problem hiding this comment.
Check currency logic in separate test
| throws IOException { | ||
| // given | ||
| final BidRequest bidRequest = givenBidRequest( | ||
| givenImp(imp -> imp.id("imp-1").banner(givenBanner()).ext(givenImpExt(PUBLISHER_ID)))); |
Collaborator
There was a problem hiding this comment.
No need to specify banner/video/etc in makeHttpRequests since you don't utilise it
Comment on lines
+111
to
+114
| assertThat(result.getValue().get(0).getPayload().getImp()).containsExactly(firstImp, thirdImp); | ||
| assertThat(result.getValue().get(0).getPayload().getExt().getProperty("bidwave").get("pid").asText()) | ||
| .isEqualTo(PUBLISHER_ID); | ||
| assertThat(result.getValue().get(0).getPayload().getCur()).containsExactly("USD"); |
Collaborator
There was a problem hiding this comment.
assertThat(result.getValue().get(0).getPayload())
.satisfies(payload -> {
assertThat(payload.getImp()).containsExactly(...);
...
})
Comment on lines
+115
to
+118
| assertThat(result.getValue().get(1).getPayload().getImp()).containsExactly(secondImp); | ||
| assertThat(result.getValue().get(1).getPayload().getExt().getProperty("bidwave").get("pid").asText()) | ||
| .isEqualTo(OTHER_PUBLISHER_ID); | ||
| assertThat(result.getValue().get(1).getPayload().getCur()).containsExactly("USD"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
What's the context?
Adds the BidWave bidder adapter to Prebid Server Java.
Rationale behind the change
Enable publishers to access BidWave demand through Prebid Server.
A dedicated adapter is used because BidWave requires publisher ID handling and USD bid-floor normalization before forwarding requests.
New Bid Adapter Checklist
Test plan
./mvnw -pl . -Dtest=org.prebid.server.bidder.bidwave.BidwaveBidderTest,org.prebid.server.it.BidwaveTest testgit diff --checkQuality check
Other info