New Adapter: Synapse HX#4532
Open
prebid-compas wants to merge 1 commit into
Open
Conversation
This was referenced Jun 8, 2026
And1sS
requested changes
Jun 15, 2026
Comment on lines
+37
to
+38
| private static final TypeReference<ExtPrebid<?, ExtImpSynapseHX>> SYNAPSE_HX_EXT_TYPE_REFERENCE = | ||
| new TypeReference<>() { }; |
Collaborator
There was a problem hiding this comment.
new TypeReference<>() {
};
Comment on lines
+40
to
+41
| private static final TypeReference<ExtPrebid<ExtBidPrebid, ?>> EXT_PREBID_TYPE_REFERENCE = | ||
| new TypeReference<>() { }; |
Comment on lines
+96
to
+105
| private static Imp validateImp(Imp imp, List<BidderError> errors) { | ||
| if (imp.getBanner() == null && imp.getVideo() == null) { | ||
| errors.add(BidderError.badInput( | ||
| "imp[%s]: Unsupported media type, bidder supports only banner and video".formatted(imp.getId()))); | ||
| return null; | ||
| } | ||
| if (imp.getXNative() != null || imp.getAudio() != null) { | ||
| return imp.toBuilder().xNative(null).audio(null).build(); | ||
| } | ||
| return imp; |
Collaborator
There was a problem hiding this comment.
This logic is not present in go + we have auction.filter-imp-media-type that will do the same job.
Comment on lines
+72
to
+79
| try { | ||
| tenantId = mapper.mapper() | ||
| .convertValue(firstImp.getExt(), SYNAPSE_HX_EXT_TYPE_REFERENCE) | ||
| .getBidder() | ||
| .getTenantId(); | ||
| } catch (IllegalArgumentException e) { | ||
| return Result.withError(BidderError.badInput("Failed to parse bidder parameters")); | ||
| } |
Collaborator
There was a problem hiding this comment.
Please, extract to separate method.
Comment on lines
+85
to
+90
| final URIBuilder uriBuilder; | ||
| try { | ||
| uriBuilder = new URIBuilder(endpoint); | ||
| } catch (URISyntaxException e) { | ||
| return Result.withError(BidderError.badInput("Invalid endpoint URI")); | ||
| } |
Collaborator
There was a problem hiding this comment.
Please, extract to separate method.
| @Test | ||
| public void makeHttpRequestsShouldReturnErrorWhenImpressionContainsOnlyAudioAndNative() { | ||
| // given | ||
| final Audio audio = Audio.builder().mimes(List.of("audio/mp3")).build(); |
Collaborator
There was a problem hiding this comment.
List.of -> static singletonList
|
|
||
| // then | ||
| assertThat(result.getValue()).isEmpty(); | ||
| assertThat(result.getErrors()).hasSize(1).contains( |
| @Test | ||
| public void makeHttpRequestsShouldRemoveAudioAndNativeFromImpressionIfItContainsSupportedMediaTypes() { | ||
| // given | ||
| final Audio audio = Audio.builder().mimes(List.of("audio/mp3")).build(); |
Comment on lines
+178
to
+201
| public void makeBidsShouldReportErrorAndSkipBidIfCannotParseBidType() throws JsonProcessingException { | ||
| // given | ||
| final BidderCall<BidRequest> httpCall = givenHttpCall(null, | ||
| givenBidResponse( | ||
| givenBid("Imp1", BidType.banner), | ||
| givenBidWithMType("Imp2", BidType.banner), | ||
| givenBid("Imp3", BidType.video), | ||
| givenBidWithMType("Imp4", BidType.video), | ||
| givenBid("Imp5", BidType.xNative), | ||
| givenBidWithMType("Imp6", BidType.xNative), | ||
| givenBid("Imp7", BidType.audio), | ||
| givenBidWithMType("Imp8", BidType.audio), | ||
| givenBid("Imp9", BidType.banner).toBuilder().ext(null).build())); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, null); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).hasSize(5).allSatisfy( | ||
| error -> assertThat( | ||
| error.getMessage()).startsWith("Unsupported media type")); | ||
| assertThat(result.getValue()).hasSize(4).allSatisfy( | ||
| bid -> assertThat(bid.getBid().getImpid()).isIn(List.of("Imp1", "Imp2", "Imp3", "Imp4"))); | ||
| } |
Collaborator
There was a problem hiding this comment.
Please, split tests into smaller pieces.
| "ext": { | ||
| "synapsehx": { | ||
| "tenantId": "tenant-id-0", | ||
| "adUnitId": "ad-unit-id-0" |
Collaborator
There was a problem hiding this comment.
Please remove unused fields, integration tests are used as happy-path tests. Logic has to be tested in unit tests. IT tests should be as simple as possible. You can take generic/test-generic-bid-request.json as a reference point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
New bidder adapter for Synapse HX
Maintainer: prebid@compas-inc.com
Related Changes
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check