Skip to content

Port Eskimi: New Adapter - #4637

Merged
And1sS merged 3 commits into
masterfrom
adapter/port-eskimi
Sep 23, 2026
Merged

And1sS merged 3 commits into
masterfrom
adapter/port-eskimi

Conversation

@osulzhenko

@osulzhenko osulzhenko commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko
osulzhenko marked this pull request as ready for review September 22, 2026 08:56
@osulzhenko osulzhenko linked an issue Sep 22, 2026 that may be closed by this pull request
Comment thread src/main/java/org/prebid/server/bidder/eskimi/EskimiBidder.java Outdated
Comment thread src/main/java/org/prebid/server/bidder/eskimi/EskimiBidder.java Outdated
Comment thread src/main/java/org/prebid/server/bidder/eskimi/EskimiBidder.java Outdated
Comment thread src/main/java/org/prebid/server/bidder/eskimi/EskimiBidder.java Outdated
Comment thread src/main/java/org/prebid/server/bidder/eskimi/EskimiBidder.java
Comment thread src/test/java/org/prebid/server/bidder/eskimi/EskimiBidderTest.java Outdated
Comment thread src/test/java/org/prebid/server/bidder/eskimi/EskimiBidderTest.java Outdated
Lightwood13
Lightwood13 previously approved these changes Sep 23, 2026
@And1sS
And1sS merged commit 81da96c into master Sep 23, 2026
7 of 8 checks passed
@And1sS
And1sS deleted the adapter/port-eskimi branch September 23, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: New Adapter: Eskimi

4 participants