Add per-component build_timeout for system test Docker builds#848
Merged
MakisH merged 9 commits intoJun 29, 2026
Conversation
Fixes precice#840. Components can set build_timeout in components.yaml; each test uses the max across its participants. DuMuX builds get 1800s by default.
MakisH
reviewed
Jun 23, 2026
MakisH
left a comment
MakisH
left a comment
Member
There was a problem hiding this comment.
Thanks for implementing! Here are some comments before testing on GHA.
Use past-tense changelog, int | None typing, 600s build timeouts for DuMuX and SU2, 300s default run/compare timeout, and clarify max build timeout behavior in docs.
MakisH
reviewed
Jun 28, 2026
Member
|
A test run for the |
MakisH
reviewed
Jun 29, 2026
MakisH
reviewed
Jun 29, 2026
MakisH
approved these changes
Jun 29, 2026
MakisH
left a comment
MakisH
left a comment
Member
There was a problem hiding this comment.
I made both timeouts a bit shorter and ran again all tests starting from a clean cache - all work: https://github.com/precice/tutorials/actions/runs/28362375986
Ready to merge!
PranjalManhgaye
added a commit
to PranjalManhgaye/tutorials
that referenced
this pull request
Jun 29, 2026
Resolve Systemtest.py conflict: keep build_timeout defaults from develop (precice#848) and fieldcompare tolerance/skip_compare from precice#847.
PranjalManhgaye
added a commit
to PranjalManhgaye/tutorials
that referenced
this pull request
Jun 30, 2026
Integrate latest develop (precice#847 tolerance/skip_compare, precice#848, precice#852, etc.) and resolve TestSuite.py conflict while keeping external: tutorial support. Set skip_compare on external suite entries now that precice#847 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_timeoutto components incomponents.yaml(build step only)dumux-adapter : build_timeout: 1800for long Dumux Docker buildsfixes Timeout for building system tests containers #840