Fix SQLAlchemy true division semantics - #753
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
TrueDivTestcompliance class.Refs #736
WHY
Athena follows Trino integer and decimal coercion rules. The default SQLAlchemy compilation produced rounded integer results, a float instead of
Decimalfor numeric literals, and a REAL precision artifact for floating-point literals. Explicit type coercion makes all SQLAlchemy true division compliance cases return the expected values and Python types.VALIDATION
just lint.venv/bin/pytest tests/pyathena/sqlalchemy/test_compiler.py::TestAthenaStatementCompiler::test_visit_truediv_binary -n 1 -q(5 passed).venv/bin/pytest tests/sqlalchemy/test_suite.py::TrueDivTest -n 1 -q(9 passed)SELF-REVIEW