lint: fix B018 failure on main - #721
Merged
RonnyPfannschmidt merged 1 commit intoAug 12, 2026
Merged
Conversation
ruff 0.16 enables flake8-bugbear by default, so the bare ``pluggy.nope`` expression added in pytest-dev#718 fails B018 and turns pre-commit.ci red on main. Bind it to ``_`` like the other attribute-access checks in that test suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit.ci - pushis failing onmain(de34583) with:Two changes landed close together and combined into this:
v0.15.22→v0.16.2, and ruff 0.16 enables flake8-bugbear in the default rule set. Bisected: 0.15.0 clean, 0.16.0 flags it.[tool.ruff.lint] extend-selectdoes not listB, so this comes purely from the new defaults.test_dunder_getattr_missing_raiseswith a barepluggy.nopeexpression. That PR already fixed four other B018 sites in 237edb6, this one was missed.The
testworkflow stays green because linting runs on pre-commit.ci, which is why the red status was easy to miss on merge.Fix binds the expression to
_, matching what 237edb6 did for_ = module.x.broken.uv run pre-commit run -aanduv run pytest(144 passed) are green with this applied.No changelog fragment — test-only lint fix, nothing user-facing.
🤖 Generated with Claude Code