Handle cross-mount paths in find_parents#714
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_parents()usesos.path.commonprefix()as a guard before callingos.path.relpath(), butcommonprefix()is character-based. On Windows UNC paths such as\\server\share1and\\server\share2\path.py, the prefix check passes even though the paths are on different mounts, andrelpath()raisesValueError.This catches that
ValueErrorand returns[], matching the existing behavior for paths outside the root. The regression test usesntpathdirectly so it covers the Windows UNC behavior on any platform.fixes #705
Tests:
python -m pytest -o addopts="" test/test_utils.py::test_find_parents_handles_cross_mount_paths test/test_utils.py::test_find_parents -qpython -m pytest -o addopts="" test/test_utils.py -qpy -3 -m ruff check pylsp/_utils.py test/test_utils.py