Speed up Image.filter() for I;16* - #9760
Open
akx wants to merge 10 commits into
Open
Conversation
Merging this PR will improve performance by ×2.5
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_filter[1237x811-L-Smooth] |
23.2 ms | 9.5 ms | ×2.5 |
| ⚡ | test_filter[1237x811-L-Sharpen] |
23.2 ms | 9.5 ms | ×2.4 |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing akx:faster-filter-still (80b9256) with main (3220aca)
Footnotes
-
335 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This comment was marked as outdated.
This comment was marked as outdated.
akx
force-pushed
the
faster-filter-still
branch
3 times, most recently
from
July 3, 2026 19:21
e2022ed to
525c545
Compare
akx
commented
Jul 4, 2026
akx
force-pushed
the
faster-filter-still
branch
4 times, most recently
from
July 5, 2026 13:50
3ca13f7 to
4666708
Compare
akx
marked this pull request as ready for review
July 5, 2026 14:07
akx
marked this pull request as draft
July 9, 2026 10:15
akx
force-pushed
the
faster-filter-still
branch
3 times, most recently
from
July 9, 2026 12:01
c448421 to
7ce5129
Compare
akx
changed the title
Image.filter() for I;16*Image.filter() for I;16*
akx
marked this pull request as ready for review
July 9, 2026 15:16
akx
marked this pull request as draft
July 17, 2026 08:08
This comment was marked as resolved.
This comment was marked as resolved.
akx
marked this pull request as ready for review
July 19, 2026 13:12
akx
changed the title
Image.filter() for I;16*Image.filter() for I;16*
Merged
Member
|
Updated from |
akx
force-pushed
the
faster-filter-still
branch
4 times, most recently
from
August 10, 2026 19:12
3dbd362 to
14c9690
Compare
radarhere
reviewed
Aug 15, 2026
| } | ||
| } else { | ||
| } else if (im->type == IMAGING_TYPE_SPECIAL) { | ||
| // Check for I;16 mode once, not per pixel |
Member
There was a problem hiding this comment.
Suggested change
| // Check for I;16 mode once, not per pixel |
Once this is merged, I don't think it's obvious what the comment is referring to
radarhere
reviewed
Aug 15, 2026
| } | ||
| } else { | ||
| } else if (im->type == IMAGING_TYPE_SPECIAL) { | ||
| // Check for I;16 mode once, not per pixel |
Member
There was a problem hiding this comment.
Suggested change
| // Check for I;16 mode once, not per pixel |
Also adds LA to some tests as a side effect
Co-authored-by: Aarni Koskela <akx@iki.fi>
akx
force-pushed
the
faster-filter-still
branch
from
August 20, 2026 06:28
bcb47ed to
80b9256
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #8438; same split-by-mode optimization technique as in #9737.
Also fixes up things around
ImageFilter:test_consistency_*tests didn't use themodeparametrization at all and just ran the same test N timestest_crashclaimed ImageFilter would crash on images smaller than the kernel; it doesn't, it just returns the same image.test_crashhad hadassert_no_exceptionsometime before 3ec5059?Kernelclaimed only a couple of modes were supported.The correctness bugs from #9786 are fixed here too.