Add strip_namespaces argument to Image.getxmp() - #9882
Open
geeno16 wants to merge 7 commits into
Open
Conversation
akx
reviewed
Aug 20, 2026
|
|
||
| def get_name(tag: str) -> str: | ||
| return re.sub("^{[^}]+}", "", tag) | ||
| return re.sub("^{[^}]+}", "", tag) if strip_namespaces else tag |
Contributor
There was a problem hiding this comment.
I'd only check the (constant-in-this-function) option once instead of every tag?
Suggested change
| return re.sub("^{[^}]+}", "", tag) if strip_namespaces else tag | |
| if strip_namespaces: | |
| def get_name(tag: str) -> str: | |
| return re.sub("^{[^}]+}", "", tag) | |
| else: | |
| def get_name(tag: str) -> str: | |
| return tag |
radarhere
reviewed
Aug 20, 2026
radarhere
approved these changes
Aug 21, 2026
radarhere
reviewed
Aug 21, 2026
radarhere
reviewed
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
strip_namespaceskeyword argument toImage.getxmp()(defaults to
True, preserving current behaviour).False, each tag keeps its full{namespace-uri}local-nameform instead of having the namespace prefix stripped.
Currently,
getxmp()always strips namespace prefixes, which can merge values from different namespaces that happen to share a local tag name. For example:Two unrelated
idtags from different namespaces (a:idandb:id) get merged into a list, with no way to tell which value came from which namespace. Withstrip_namespaces=False: